code review 4548073: gc: disallow ... in type conversions

gc: disallow ... in type conversions

Fixes issue 1866.

[ality, 2011-05-30 15:34:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-30 16:43:05]

On Mon, May 30, 2011 at 8:34 AM, <ality@pbrane.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gc: disallow ... in type conversions
>
> Fixes issue 1866.
>

It doesn't fix anything for long if there's no new test.


>
> Please review this at http://codereview.appspot.com/4548073/
>
> Affected files:
>  M src/cmd/gc/typecheck.c
>

[ality, 2011-05-30 16:58:24]

Brad Fitzpatrick <bradfitz@golang.org> once said:
> It doesn't fix anything for long if there's no new test.

Yeah, sorry about that.  Usually when I fix a bug in the
compiler, I'll add a file in test/fixedbugs but I wasn't
quite sure with this one.  It could go in test/ddd1.go
with all the other "..." errors.

Thoughts?

  Anthony

[bradfitz, 2011-05-30 17:05:48]

On Mon, May 30, 2011 at 9:57 AM, Anthony Martin <ality@pbrane.org> wrote:

> Brad Fitzpatrick <bradfitz@golang.org> once said:
> > It doesn't fix anything for long if there's no new test.
>
> Yeah, sorry about that.  Usually when I fix a bug in the
> compiler, I'll add a file in test/fixedbugs but I wasn't
> quite sure with this one.  It could go in test/ddd1.go
> with all the other "..." errors.
>
> Thoughts?
>

I've never fixed a bug in the compiler or even entered the test/ directory
so I wouldn't necessarily listen to me, but ddd1.go sounds like a decent
place.

[rsc, 2011-05-30 20:00:24]

ddd1 is fine

[ality, 2011-05-31 02:52:19]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-05-31 18:38:30]

LGTM

[rsc, 2011-05-31 19:41:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=0d10a13d15c0 ***

gc: disallow ... in type conversions

Fixes issue 1866.

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4548073

Committer: Russ Cox <rsc@golang.org>