Issue 4539109: code review 4539109: unicode: for consistency with MaxRune, s/Latin1Max/MaxL...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4539109: code review 4539109: unicode: for consistency with MaxRune, s/Latin1Max/MaxL... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, r2, gri

Visibility:
Public.

Description

unicode: for consistency with MaxRune, s/Latin1Max/MaxLatin1/ and s/ASCIIMax/MaxASCII/

Patch Set 1 #

Patch Set 2 : diff -r 23c4961fcea2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 23c4961fcea2 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -33 lines)			Patch
M	src/pkg/unicode/digit.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/digit_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/graphic.go	View	1	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/unicode/graphic_test.go	View	1	10 chunks	+10 lines, -10 lines	0 comments	Download
M	src/pkg/unicode/letter.go	View	1	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/pkg/unicode/letter_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/maketables.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/unicode/tables.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-03 22:28:54 UTC) #1

Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2011-06-03 22:58:02 UTC) #3

13 years, 10 months ago (2011-06-03 23:28:33 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d9401fa9dc01 ***

unicode: for consistency with MaxRune, s/Latin1Max/MaxLatin1/ and
s/ASCIIMax/MaxASCII/

R=golang-dev, r, gri
CC=golang-dev
http://codereview.appspot.com/4539109

Expand All Messages | Collapse All Messages