code review 4532115: crypto: reorg, cleanup and add function for generating CRLs.

crypto: reorg, cleanup and add function for generating CRLs.

This change moves a number of common PKIX structures into
crypto/x509/pkix, from where x509, and ocsp can reference
them, saving duplication. It also removes x509/crl and merges it into
x509 and x509/pkix.

x509 is changed to take advantage of the big.Int support that now
exists in asn1. Because of this, the public/private key pair in
http/httptest/server.go had to be updated because it was serialised
with an old version of the code that didn't zero pad ASN.1 INTEGERs.

[agl1, 2011-06-03 20:13:00]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-03 20:18:50]

Should crl be merged into pkix?

[agl1, 2011-06-03 20:47:53]

On Fri, Jun 3, 2011 at 4:18 PM, Russ Cox <rsc@golang.org> wrote:
> Should crl be merged into pkix?

There are both quite small I guess. Done.


Cheers

AGL

[bradfitz, 2011-06-03 20:57:10]

LGTM

Just skimmed it though.  Not a super thorough review.

http://codereview.appspot.com/4532115/diff/14001/src/pkg/crypto/x509/x509_tes...
File src/pkg/crypto/x509/x509_test.go (right):

http://codereview.appspot.com/4532115/diff/14001/src/pkg/crypto/x509/x509_tes...
src/pkg/crypto/x509/x509_test.go:380: func fromBase64(in string) []byte {
FYI only, there's this now:

http://tip.goneat.org/pkg/encoding/base64/#Encoding.DecodeString

doesn't do your panic, though, so not really a replacement here.

[agl1, 2011-06-06 14:35:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=7164c59c6857 ***

crypto: reorg, cleanup and add function for generating CRLs.

This change moves a number of common PKIX structures into
crypto/x509/pkix, from where x509, and ocsp can reference
them, saving duplication. It also removes x509/crl and merges it into
x509 and x509/pkix.

x509 is changed to take advantage of the big.Int support that now
exists in asn1. Because of this, the public/private key pair in
http/httptest/server.go had to be updated because it was serialised
with an old version of the code that didn't zero pad ASN.1 INTEGERs.

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4532115