code review 4528123: godefs: rudimentary tests

godefs: rudimentary tests

currently only defined for darwin

[rh, 2011-06-04 17:08:47]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-06-05 22:09:29]

thanks for this.

i'm not thrilled about baking issue names as files in the code tree. why not
just make a single test file and put comments in if you wish to reference the
original bugs?

[rh, 2011-06-06 10:50:38]

Thank you for the review.

PTAL.  It now uses a single test file.

[r, 2011-06-06 11:51:56]

the Makefile should run the test and the test should be invoked by run.bash.

http://codereview.appspot.com/4528123/diff/11001/src/cmd/godefs/testdata.c
File src/cmd/godefs/testdata.c (right):

http://codereview.appspot.com/4528123/diff/11001/src/cmd/godefs/testdata.c#ne...
src/cmd/godefs/testdata.c:7: // Issue 432
so i don't have to look it up, please add one line explaining the issue.

[rh, 2011-06-15 01:14:59]

Thanks for the review... sorry for the delay. PTAL.

http://codereview.appspot.com/4528123/diff/11001/src/cmd/godefs/testdata.c
File src/cmd/godefs/testdata.c (right):

http://codereview.appspot.com/4528123/diff/11001/src/cmd/godefs/testdata.c#ne...
src/cmd/godefs/testdata.c:7: // Issue 432
On 2011/06/06 11:51:56, r wrote:
> so i don't have to look it up, please add one line explaining the issue.

Done.

[r, 2011-06-15 01:42:13]

LGTM
thanks

[r, 2011-06-20 01:54:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=7fa271653bf2 ***

godefs: rudimentary tests

currently only defined for darwin

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4528123

Committer: Rob Pike <r@golang.org>