code review 4528116: gc: typecheck the whole tree before walking. preparati...

gc: typecheck the whole tree before walking.  preparation for some escape-analysis related changes.

[lvd, 2011-06-02 16:12:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[lvd, 2011-06-02 16:18:26]

On 2011/06/02 16:12:25, lvd wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

tested by ./all.bash with GOARCH= all three, even though on 10.5 only the amd64
can actually run.  assuming that if the compiler did not throw up 'missing
typecheck' Nothing Could Possibly Go Wrong.

[rsc, 2011-06-02 16:25:28]

LGTM

http://codereview.appspot.com/4528116/diff/4001/src/cmd/5g/ggen.c
File src/cmd/5g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/5g/ggen.c#newcode11
src/cmd/5g/ggen.c:11: defframe(Prog *ptxt) {
brace on next line

http://codereview.appspot.com/4528116/diff/4001/src/cmd/6g/ggen.c
File src/cmd/6g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/6g/ggen.c#newcode11
src/cmd/6g/ggen.c:11: defframe(Prog *ptxt) {
brace on next line

http://codereview.appspot.com/4528116/diff/4001/src/cmd/8g/ggen.c
File src/cmd/8g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/8g/ggen.c#newcode11
src/cmd/8g/ggen.c:11: defframe(Prog *ptxt) {
brace on next line

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/lex.c
File src/cmd/gc/lex.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/lex.c#newcode258
src/cmd/gc/lex.c:258: typechecklist((curfn = l->n)->nbody, Etop);
please use braces { } and a separate statement.  curfn = l->n;
typechecklist(curfn->nbody, Etop);

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/pgen.c
File src/cmd/gc/pgen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/pgen.c#newcode4
src/cmd/gc/pgen.c:4: // Portable part of ggen.c moved from {568}g/ to gc/
delete; make this a blank line

[lvd, 2011-06-02 16:30:51]

all done

http://codereview.appspot.com/4528116/diff/4001/src/cmd/5g/ggen.c
File src/cmd/5g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/5g/ggen.c#newcode11
src/cmd/5g/ggen.c:11: defframe(Prog *ptxt) {
On 2011/06/02 16:25:29, rsc wrote:
> brace on next line

gaaaa done

http://codereview.appspot.com/4528116/diff/4001/src/cmd/6g/ggen.c
File src/cmd/6g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/6g/ggen.c#newcode11
src/cmd/6g/ggen.c:11: defframe(Prog *ptxt) {
On 2011/06/02 16:25:29, rsc wrote:
> brace on next line

gaaaa done

http://codereview.appspot.com/4528116/diff/4001/src/cmd/8g/ggen.c
File src/cmd/8g/ggen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/8g/ggen.c#newcode11
src/cmd/8g/ggen.c:11: defframe(Prog *ptxt) {
On 2011/06/02 16:25:29, rsc wrote:
> brace on next line

gaaa done

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/lex.c
File src/cmd/gc/lex.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/lex.c#newcode258
src/cmd/gc/lex.c:258: typechecklist((curfn = l->n)->nbody, Etop);
On 2011/06/02 16:25:29, rsc wrote:
> please use braces { } and a separate statement.  curfn = l->n;
> typechecklist(curfn->nbody, Etop);
> 

i knew you were gonna say that.  done.

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/pgen.c
File src/cmd/gc/pgen.c (right):

http://codereview.appspot.com/4528116/diff/4001/src/cmd/gc/pgen.c#newcode4
src/cmd/gc/pgen.c:4: // Portable part of ggen.c moved from {568}g/ to gc/
On 2011/06/02 16:25:29, rsc wrote:
> delete; make this a blank line
> 

Done.

[lvd, 2011-06-02 16:48:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=1ad9c6bde8e3 ***

gc: typecheck the whole tree before walking.  preparation for some
escape-analysis related changes.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4528116