Issue 4528113: code review 4528113: syscall: add socket control message support for darwin,...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4528113: code review 4528113: syscall: add socket control message support for darwin,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by mikio

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: add socket control message support for darwin, freebsd, linux

Patch Set 1 : diff -r 4d789ab9a41d https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 4d510d32c397 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4d510d32c397 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -13 lines)			Patch
M	src/pkg/syscall/Makefile	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/route_bsd.go	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A	src/pkg/syscall/sockcmsg_unix.go	View		1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_bsd.go	View		2 chunks	+74 lines, -8 lines	0 comments	Download
M	src/pkg/syscall/syscall_darwin_386.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_darwin_amd64.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_freebsd_386.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_freebsd_amd64.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/syscall_unix.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_amd64.go	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-19 15:57:49 UTC) #1

mikio

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 9 months ago (2011-06-20 22:05:46 UTC) #3

rsc

13 years, 9 months ago (2011-06-20 22:40:22 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b09efb10f127 ***

syscall: add socket control message support for darwin, freebsd, linux

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4528113

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages