code review 4517147: syscall: adding ptrace on darwin

syscall: adding ptrace on darwin

The ptrace syscall remains gutted on darwin, but usable. This also makes the syscall addition process reproducible on darwin instead of relying on a file path in rsc's home directory. I've also removed an override of $PATH in env.bash that made tooling harder.

[jmhodges, 2011-06-09 05:12:24]

Hello rsc@golang.org (cc: dayveday@gmail.com, golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[jmhodges, 2011-06-13 18:30:46]

Ping?

[jmhodges, 2011-06-14 03:50:11]

Hello rsc@golang.org, dave@cheney.net (cc: dave@cheney.net,
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-06-14 04:07:35]

http://codereview.appspot.com/4517147/diff/12001/src/pkg/syscall/mksysnum_dar...
File src/pkg/syscall/mksysnum_darwin.pl (right):

http://codereview.appspot.com/4517147/diff/12001/src/pkg/syscall/mksysnum_dar...
src/pkg/syscall/mksysnum_darwin.pl:23: my $num = $2;
strange indentation or just codereview misformatting?

[jmhodges, 2011-06-14 04:12:37]

http://codereview.appspot.com/4517147/diff/12001/src/pkg/syscall/mksysnum_dar...
File src/pkg/syscall/mksysnum_darwin.pl (right):

http://codereview.appspot.com/4517147/diff/12001/src/pkg/syscall/mksysnum_dar...
src/pkg/syscall/mksysnum_darwin.pl:23: my $num = $2;
On 2011/06/14 04:07:35, r wrote:
> strange indentation or just codereview misformatting?

Strange indenting. perl-mode not set up correctly.

[jmhodges, 2011-06-14 04:12:52]

Hello rsc@golang.org, dave@cheney.net, r@golang.org (cc: dave@cheney.net,
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-06-14 04:26:50]

leaving for rsc. it's his name you're removing.

[dave_cheney.net, 2011-06-14 04:30:04]

Using this sample code provided by jmhodges this works as advertised on
darwin/amd64.

[rsc, 2011-06-14 15:18:40]

LGTM

Thanks.  This is much cleaner.
Please update the comment in mksysnum_darwin and I will submit

http://codereview.appspot.com/4517147/diff/17001/src/pkg/syscall/mksysnum_dar...
File src/pkg/syscall/mksysnum_darwin.pl (right):

http://codereview.appspot.com/4517147/diff/17001/src/pkg/syscall/mksysnum_dar...
src/pkg/syscall/mksysnum_darwin.pl:6: # Generate system call table for Darwin
from master list
Update comment.

[jmhodges, 2011-06-14 16:53:14]

Hello rsc@golang.org, dave@cheney.net, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-14 16:54:46]

LGTM

[rsc, 2011-06-14 16:56:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=2c8050925cc4 ***

syscall: add ptrace on darwin

The ptrace syscall remains gutted on darwin, but usable.  This
also makes the syscall addition process reproducible on darwin
instead of relying on a file path in rsc's home directory.
I've also removed an override of $PATH in env.bash that made
tooling harder.

R=rsc, dave, r
CC=golang-dev
http://codereview.appspot.com/4517147

Committer: Russ Cox <rsc@golang.org>