Issue 4515124: code review 4515124: syscall: add IPv6 scope zone ID support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515124: code review 4515124: syscall: add IPv6 scope zone ID support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by mikio

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

syscall: add IPv6 scope zone ID support

Patch Set 1 #

Patch Set 2 : diff -r e1a22bb01cf2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e1a22bb01cf2 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	src/pkg/syscall/syscall_bsd.go	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-05-22 10:26:49 UTC) #1

bradfitz

Is there a technical reason for naming it ZoneId instead of ScopeId?

12 years, 11 months ago (2011-05-22 16:55:56 UTC) #2

mikio

On Mon, May 23, 2011 at 1:55 AM, <bradfitz@golang.org> wrote: > Is there a technical ...

12 years, 11 months ago (2011-05-22 17:02:34 UTC) #3

bradfitz

LGTM I'll take your word for it. I see just as many references to "scope" ...

12 years, 11 months ago (2011-05-22 17:09:07 UTC) #4

bradfitz

12 years, 11 months ago (2011-05-22 17:09:10 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=fef68b8eefba ***

syscall: add IPv6 scope zone ID support

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4515124

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages