Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 44850043: code review 44850043: .hgignore: add comment setting policy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by r
Modified:
10 years, 5 months ago
Reviewers:
dsymonds, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

.hgignore: add comment setting policy

Patch Set 1 #

Patch Set 2 : diff -r 9edfc37f383f https://code.google.com/p/go.image #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.image
10 years, 5 months ago (2013-12-21 00:17:08 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
10 years, 5 months ago (2013-12-21 00:19:45 UTC) #2
rsc
LGTM
10 years, 5 months ago (2013-12-21 00:22:37 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=21b73434ebf0&repo=image *** .hgignore: add comment setting policy R=golang-codereviews, rsc CC=golang-codereviews https://codereview.appspot.com/44850043
10 years, 5 months ago (2013-12-21 00:30:03 UTC) #4
dsymonds
LGTM but maybe ditch the double negative? # Only add patterns for files generated by ...
10 years, 5 months ago (2013-12-21 01:46:56 UTC) #5
r
I prefer the forcefulness of "Add no patterns" as an opener.
10 years, 5 months ago (2013-12-21 04:22:41 UTC) #6
dsymonds
10 years, 5 months ago (2013-12-21 06:00:25 UTC) #7
LGTM

I will make no objections.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b