runtime: fix and improve CPU profiling
- do not lose profiling signals when we have no mcache (possible for syscalls/cgo)
- do not lose any profiling signals on windows
- fix profiling of cgo programs on windows (they had no m->thread setup)
- properly setup tls in cgo programs on windows
- check _beginthread return value
Fixes issue 6417.
Fixes issue 6986.
Hello alex.brainman@gmail.com, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 2 months ago
(2013-12-23 18:11:21 UTC)
#1
https://codereview.appspot.com/44820047/diff/80001/src/pkg/runtime/os_windows.c File src/pkg/runtime/os_windows.c (right): https://codereview.appspot.com/44820047/diff/80001/src/pkg/runtime/os_windows.c#newcode249 src/pkg/runtime/os_windows.c:249: runtimeĀ·atomicstorep(&m->thread, thandle); this location works for main thread, normal ...
11 years, 2 months ago
(2013-12-23 18:13:38 UTC)
#2
*** Submitted as https://code.google.com/p/go/source/detail?r=72c0dfd50949 *** runtime: fix and improve CPU profiling - do not lose ...
11 years, 1 month ago
(2014-01-22 06:30:20 UTC)
#7
*** Submitted as https://code.google.com/p/go/source/detail?r=72c0dfd50949 ***
runtime: fix and improve CPU profiling
- do not lose profiling signals when we have no mcache (possible for
syscalls/cgo)
- do not lose any profiling signals on windows
- fix profiling of cgo programs on windows (they had no m->thread setup)
- properly setup tls in cgo programs on windows
- check _beginthread return value
Fixes issue 6417.
Fixes issue 6986.
R=alex.brainman, rsc
CC=golang-codereviews
https://codereview.appspot.com/44820047
Issue 44820047: code review 44820047: runtime: fix and improve CPU profiling
(Closed)
Created 11 years, 2 months ago by dvyukov
Modified 11 years, 1 month ago
Reviewers: brainman
Base URL:
Comments: 3