Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 4452050: code review 4452050: tutorial: replace the forever loops with finite counts ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
CC:
brainman, rsc, peterGo, golang-dev
Visibility:
Public.

Description

tutorial: replace the forever loops with finite counts in sieve programs. Fixes issue 1742. I hope. Also this picks up an update to go_tutorial.html that should already have happened.

Patch Set 1 #

Patch Set 2 : diff -r 0521ecb3b159 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 66fd38761bab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M doc/go_tutorial.html View 4 chunks +27 lines, -25 lines 0 comments Download
M doc/progs/sieve.go View 1 chunk +1 line, -1 line 0 comments Download
M doc/progs/sieve1.go View 1 chunk +1 line, -1 line 0 comments Download
M src/run.bash View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
r
Hello alex.brainman@gmail.com, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-04-26 23:57:39 UTC) #1
rsc
LGTM
13 years, 11 months ago (2011-04-27 01:18:25 UTC) #2
brainman
You always find simple solution. It builds successfully. Except, this message: --- cd ../doc/progs helloworld3 ...
13 years, 11 months ago (2011-04-27 01:30:37 UTC) #3
peterGo
Alex, On linux/amd64, when running ./all.bash I see: --- cd ../doc/progs real 0m2.175s user 0m2.030s ...
13 years, 11 months ago (2011-04-27 02:52:45 UTC) #4
brainman
On 2011/04/27 02:52:45, peterGo wrote: > Alex, > > On linux/amd64, ... I didn't test ...
13 years, 11 months ago (2011-04-27 02:57:23 UTC) #5
peterGo
Alex , On Windows, the problem is that you are running the Unix test: testit ...
13 years, 11 months ago (2011-04-27 03:27:23 UTC) #6
r
13 years, 11 months ago (2011-04-27 16:59:31 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=9658399fdd33 ***

tutorial: replace the forever loops with finite counts in sieve programs.
Fixes issue 1742.
I hope.

Also this picks up an update to go_tutorial.html that should already have
happened.

R=brainman, rsc, peterGo
CC=golang-dev
http://codereview.appspot.com/4452050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b