Issue 4444049: code review 4444049: reflect: allow Slice of arrays

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4444049: code review 4444049: reflect: allow Slice of arrays (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r c1b858bc04cd https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 44d9b2c594a8 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -17 lines)			Patch
M	src/cmd/gc/reflect.c	View	1	2 chunks	+19 lines, -9 lines	0 comments	Download
M	src/pkg/reflect/all_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/reflect/type.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/reflect/value.go	View	1 2	1 chunk	+18 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/type.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-18 23:45:19 UTC) #1

LGTM after updating comment http://codereview.appspot.com/4444049/diff/2001/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): http://codereview.appspot.com/4444049/diff/2001/src/pkg/reflect/value.go#newcode1248 src/pkg/reflect/value.go:1248: // It panics if v's ...

13 years, 11 months ago (2011-04-18 23:50:52 UTC) #2

rsc

13 years, 11 months ago (2011-04-19 00:00:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=da956632c61b ***

reflect: allow Slice of arrays

R=r
CC=golang-dev
http://codereview.appspot.com/4444049

Expand All Messages | Collapse All Messages