Issue 4442064: code review 4442064: src/pkg: make package doc comments consistently start w...

Issue 4442064: code review 4442064: src/pkg: make package doc comments consistently start w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by nigeltao

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

src/pkg: make package doc comments consistently start with "Package foo".

Patch Set 1 #

Patch Set 2 : diff -r 457779d45121 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 457779d45121 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1c953954868a https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -183 lines)			Patch
M	doc/effective_go.html	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/archive/tar/common.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/archive/zip/reader.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/asn1/asn1.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/big/nat.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/bufio/bufio.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bytes/bytes.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/cmath/abs.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/compress/flate/inflate.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/compress/gzip/gunzip.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/compress/lzw/reader.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/compress/zlib/reader.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/container/heap/heap.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/container/list/list.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/container/ring/ring.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/container/vector/defs.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/aes/const.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/blowfish/cipher.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/cast5/cast5.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/cipher/cipher.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/crypto.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/elliptic/elliptic.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/hmac/hmac.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/md4/md4.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/md5/md5.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/ocsp/ocsp.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/armor/armor.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/error/error.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/packet/packet.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/read.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/s2k/s2k.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/rc4/rc4.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/ripemd160/ripemd160.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/rsa/rsa.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/sha1/sha1.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/sha256/sha256.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/crypto/sha512/sha512.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/crypto/subtle/constant_time.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/tls/tls.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/crypto/twofish/twofish.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/xtea/cipher.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/debug/dwarf/open.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/ebnf/ebnf.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/hex/hex.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/encoding/line/line.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/encoding/pem/pem.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exec/exec.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/datafmt/datafmt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/draw/x11/conn.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/eval/world.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ogle/cmd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/expvar/expvar.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/flag/flag.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/ast/ast.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/doc/doc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/scanner/scanner.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/token/token.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/go/types/types.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/gob/doc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/hash/adler32/adler32.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/hash/crc32/crc32.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/hash/crc64/crc64.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/hash/fnv/fnv.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/hash/hash.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/html/doc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/httptest/recorder.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/request.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/image/image.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/image/png/reader.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/image/ycbcr/ycbcr.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/index/suffixarray/suffixarray.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/io/io.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/json/encode.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/log/log.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/math/const.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/mime/type.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/net.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/net/textproto/textproto.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/netchan/export.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/os/inotify/inotify_linux.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/path/filepath/path.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/path/path.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/reflect/type.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/rpc/server.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/debug/stack.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/extern.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/scanner/scanner.go	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/pkg/sort/sort.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/strconv/atof.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/strings/strings.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/sync/mutex.go	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/syscall.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syslog/syslog.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/pkg/tabwriter/tabwriter.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/template/template.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/testing/iotest/reader.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/testing/quick/quick.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/testing/script/script.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/testing/testing.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/time/time.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/unicode/letter.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/unsafe/unsafe.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/utf8/utf8.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/websocket/websocket.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-19 08:24:25 UTC) #1

nigeltao

13 years, 11 months ago (2011-04-19 23:57:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5ddd27ff66f6 ***

src/pkg: make package doc comments consistently start with "Package foo".

R=rsc
CC=golang-dev
http://codereview.appspot.com/4442064

Expand All Messages | Collapse All Messages