Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(266)

Issue 4440062: code review 4440062: fmt: decrease recursion depth (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by iant
Modified:
13 years, 11 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

fmt: decrease recursion depth This permits the test to run when using gccgo on system without split-stack support. See http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01420.html http://gcc.gnu.org/PR48553

Patch Set 1 #

Patch Set 2 : diff -r 6f45b9b388e0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6f45b9b388e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6f45b9b388e0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/pkg/fmt/scan_test.go View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-04-22 23:11:43 UTC) #1
r
LGTM but 800 is an arbitrary enough number to deserve a comment.
13 years, 11 months ago (2011-04-22 23:22:25 UTC) #2
iant
13 years, 11 months ago (2011-04-22 23:59:38 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=fa228f08fb5c ***

fmt: decrease recursion depth

This permits the test to run when using gccgo on system
without split-stack support.  See
http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01420.html
http://gcc.gnu.org/PR48553

R=r
CC=golang-dev
http://codereview.appspot.com/4440062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b