Issue 4430045: code review 4430045: test/bench: update timings; moving to new machine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4430045: code review 4430045: test/bench: update timings; moving to new machine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by r

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

test/bench: update timings; moving to new machine. Interesting comparisons between old and new machine, and relationship between gccgo and gc.

Patch Set 1 #

Patch Set 2 : diff -r cfe69c1fe57b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 80730c0ed22d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ad82ac65f73c https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -0 lines)			Patch
	M	test/bench/timing.log	View	1 2	1 chunk	+170 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-15 19:41:57 UTC) #1

rsc1

Can you run one more on the old machine and put those numbers above these?

13 years, 11 months ago (2011-04-15 19:49:08 UTC) #2

Hello golang-dev@googlegroups.com, rsc1 (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-04-15 21:01:40 UTC) #3

Hello golang-dev@googlegroups.com, rsc1 (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-04-18 16:29:14 UTC) #4

13 years, 11 months ago (2011-04-18 16:50:26 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=e97367507c63 ***

test/bench: update timings; moving to new machine.
Interesting comparisons between old and new machine,
and relationship between gccgo and gc.

R=golang-dev, rsc1
CC=golang-dev
http://codereview.appspot.com/4430045

Expand All Messages | Collapse All Messages