Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(784)

Issue 4426069: code review 4426069: http: add Header.Write method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by eds
Modified:
13 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz, dsymonds
Visibility:
Public.

Description

http: add Header.Write method

Patch Set 1 #

Patch Set 2 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 5 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 9 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r ff32eff02b8e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -50 lines) Patch
M src/pkg/http/cgi/child.go View 1 2 3 4 9 1 chunk +2 lines, -11 lines 0 comments Download
M src/pkg/http/fcgi/child.go View 1 2 3 4 9 1 chunk +1 line, -9 lines 0 comments Download
M src/pkg/http/header.go View 1 2 3 4 5 6 7 8 9 10 2 chunks +39 lines, -1 line 0 comments Download
A src/pkg/http/header_test.go View 1 2 3 4 5 6 7 8 9 1 chunk +71 lines, -0 lines 0 comments Download
M src/pkg/http/request.go View 1 2 3 4 9 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/response.go View 1 2 3 4 9 3 chunks +1 line, -27 lines 0 comments Download
M src/pkg/http/server.go View 1 2 3 4 9 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13
eds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-04-28 05:10:15 UTC) #1
bradfitz
You should probably add a couple tests for this method too. http://codereview.appspot.com/4426069/diff/5001/src/pkg/http/cgi/child.go File src/pkg/http/cgi/child.go (right): ...
13 years, 10 months ago (2011-04-28 05:18:19 UTC) #2
eds
Hello golang-dev@googlegroups.com, bradfitz (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-04-28 05:26:52 UTC) #3
bradfitz
Amuse me with a test or two? On Wed, Apr 27, 2011 at 10:26 PM, ...
13 years, 10 months ago (2011-04-28 05:30:27 UTC) #4
eds
On Thu, Apr 28, 2011 at 5:30 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Amuse me ...
13 years, 10 months ago (2011-04-28 05:33:07 UTC) #5
eds
Hello golang-dev@googlegroups.com, bradfitz (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-04-28 05:48:46 UTC) #6
bradfitz
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go File src/pkg/http/header.go (right): http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go#newcode73 src/pkg/http/header.go:73: return nil I think we can/should make this include ...
13 years, 10 months ago (2011-04-28 06:02:08 UTC) #7
eds
Hello golang-dev@googlegroups.com, bradfitz (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-04-28 06:17:04 UTC) #8
dsymonds
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go File src/pkg/http/header.go (right): http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go#newcode73 src/pkg/http/header.go:73: return nil On 2011/04/28 06:02:08, bradfitz wrote: > I ...
13 years, 10 months ago (2011-04-28 06:23:17 UTC) #9
bradfitz
On Wed, Apr 27, 2011 at 11:23 PM, <dsymonds@golang.org> wrote: > > http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go > File ...
13 years, 10 months ago (2011-04-28 06:40:21 UTC) #10
eds
Hello golang-dev@googlegroups.com, bradfitz, dsymonds (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-04-28 07:04:01 UTC) #11
bradfitz
LGTM On Thu, Apr 28, 2011 at 12:04 AM, <chickencha@gmail.com> wrote: > Hello golang-dev@googlegroups.com, bradfitz, ...
13 years, 10 months ago (2011-04-28 07:13:57 UTC) #12
bradfitz
13 years, 10 months ago (2011-04-28 07:16:18 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=4abcd1a58d3d ***

http: add Header.Write method

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
http://codereview.appspot.com/4426069

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b