You should probably add a couple tests for this method too. http://codereview.appspot.com/4426069/diff/5001/src/pkg/http/cgi/child.go File src/pkg/http/cgi/child.go (right): ...
13 years, 10 months ago
(2011-04-28 05:18:19 UTC)
#2
On Thu, Apr 28, 2011 at 5:30 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Amuse me ...
13 years, 10 months ago
(2011-04-28 05:33:07 UTC)
#5
On Thu, Apr 28, 2011 at 5:30 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Amuse me with a test or two?
Sorry, I was checking off the inline comments and forgot that one.
Tests coming up.
- Evan
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go File src/pkg/http/header.go (right): http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go#newcode73 src/pkg/http/header.go:73: return nil I think we can/should make this include ...
13 years, 10 months ago
(2011-04-28 06:02:08 UTC)
#7
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go File src/pkg/http/header.go (right): http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go#newcode73 src/pkg/http/header.go:73: return nil On 2011/04/28 06:02:08, bradfitz wrote: > I ...
13 years, 10 months ago
(2011-04-28 06:23:17 UTC)
#9
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go
File src/pkg/http/header.go (right):
http://codereview.appspot.com/4426069/diff/8002/src/pkg/http/header.go#newcode73
src/pkg/http/header.go:73: return nil
On 2011/04/28 06:02:08, bradfitz wrote:
> I think we can/should make this include the final \r\n.
Sorry, can I disagree here? The separating "\r\n" is not semantically part of
the header (I think the RFC talks about it as a separator between the header and
body). Adding it here also messes with re-using this code for HTTP Trailers (if
we ever get to implementing them), and it makes printing out this object (e.g.
for debugging) have an unnecessary blank line at the end.
Issue 4426069: code review 4426069: http: add Header.Write method
(Closed)
Created 13 years, 10 months ago by eds
Modified 13 years, 10 months ago
Reviewers:
Base URL:
Comments: 7