Issue 4425060: code review 4425060: mime/multipart: limit line length to prevent abuse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4425060: code review 4425060: mime/multipart: limit line length to prevent abuse (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bradfitz

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

mime/multipart: limit line length to prevent abuse Fixes issue 1528

Patch Set 1 #

Patch Set 2 : diff -r 9658d8fbd2a0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9658d8fbd2a0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9658d8fbd2a0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 96744c61ffcf https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	src/pkg/mime/multipart/multipart.go	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/pkg/mime/multipart/multipart_test.go	View	1 2 3	2 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-04-20 21:36:17 UTC) #1

rsc

LGTM I'd drop the changes to NewReader and just let bufio use its default. Then ...

13 years, 1 month ago (2011-04-21 13:14:24 UTC) #2

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 1 month ago (2011-04-21 17:43:39 UTC) #3

bradfitz

13 years, 1 month ago (2011-04-21 17:46:02 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c4b835aa75c1 ***

mime/multipart: limit line length to prevent abuse

Fixes issue 1528

R=rsc
CC=golang-dev
http://codereview.appspot.com/4425060

Expand All Messages | Collapse All Messages