Issue 4417042: code review 4417042: govet: make name-matching for printf etc. case-insensitive.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4417042: code review 4417042: govet: make name-matching for printf etc. case-insensitive. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by r

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, gri, golang-dev

Visibility:
Public.

Description

govet: make name-matching for printf etc. case-insensitive. Update goyacc, cgo to be more canonical in their naming and silence the new warnings.

Patch Set 1 #

Patch Set 2 : diff -r 0c04a6cdc439 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -131 lines)			Patch
M	src/cmd/cgo/ast.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/cgo/gcc.go	View	18 chunks	+29 lines, -29 lines	0 comments	Download
M	src/cmd/cgo/main.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/cgo/util.go	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/govet/govet.go	View	3 chunks	+27 lines, -17 lines	0 comments	Download
M	src/cmd/goyacc/goyacc.go	View	42 chunks	+55 lines, -55 lines	0 comments	Download
M	src/cmd/goyacc/units.y	View	13 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-13 22:59:20 UTC) #1

13 years, 11 months ago (2011-04-13 23:57:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b61e0f1a980c ***

govet: make name-matching for printf etc. case-insensitive.
Update goyacc, cgo to be more canonical in their naming and silence the new
warnings.

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/4417042

Expand All Messages | Collapse All Messages