code review 4413042: build: tidy intermediate files during build

build: tidy intermediate files during build

This CL changes the behavior of 'make install' and 'make test'
in the src/cmd directory and the src/pkg directory to have
each recursive make clean up after itself immediately.

It does the same in test/run, removing $F.$A and $A.out
(the common byproducts) between runs.

On machines with slow disks and aggressive kernel caching,
cleaning up immediately can mean that the intermediate
objects never get written to disk.

This change eliminates almost all the disk waiting during
all.bash on my laptop (a Thinkpad X201s with an SSD running Linux).

147.50u 19.95s 277.34r	before
148.53u 21.64s 179.59r	after

[rsc, 2011-04-13 18:43:13]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-04-13 19:31:49]

LGTM, with trepidation

[iant2, 2011-04-13 19:50:07]

LGTM

rsc@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: tidy intermediate files during build
>
> This CL changes the behavior of 'make install' and 'make test'
> in the src/cmd directory and the src/pkg directory to have
> each recursive make clean up after itself immediately.
>
> It does the same in test/run, removing $F.$A and $A.out
> (the common byproducts) between runs.
>
> On machines with slow disks and aggressive kernel caching,
> cleaning up immediately can mean that the intermediate
> objects never get written to disk.
>
> This change eliminates almost all the disk waiting during
> all.bash on my laptop (a Thinkpad X201s with an SSD running Linux).
>
> 147.50u 19.95s 277.34r	before
> 148.53u 21.64s 179.59r	after
>
> Please review this at http://codereview.appspot.com/4413042/
>
> Affected files:
>   M src/Make.common
>   M src/pkg/Makefile
>   M test/run
>
>
> Index: src/Make.common
> ===================================================================
> --- a/src/Make.common
> +++ b/src/Make.common
> @@ -5,6 +5,15 @@
>  clean:
>  	rm -rf *.o *.a *.[$(OS)] [$(OS)].out $(CLEANFILES)
>
> +install.clean: install
> +	rm -rf *.o *.a *.[$(OS)] [$(OS)].out $(CLEANFILES)
> +
> +test.clean: test
> +	rm -rf *.o *.a *.[$(OS)] [$(OS)].out $(CLEANFILES)
> +
> +testshort.clean: testshort
> +	rm -rf *.o *.a *.[$(OS)] [$(OS)].out $(CLEANFILES)
> +
>  %.make:
>  	$(MAKE) -C $* install
>
> Index: src/pkg/Makefile
> ===================================================================
> --- a/src/pkg/Makefile
> +++ b/src/pkg/Makefile
> @@ -233,18 +233,18 @@
>
>  %.install:
>  	+@echo install $*
> -	+@$(MAKE) -C $* install >$*/build.out 2>&1 || (echo INSTALL
> FAIL $*; cat $*/build.out; exit 1)
> +	+@$(MAKE) -C $* install.clean >$*/build.out 2>&1 || (echo
> INSTALL FAIL $*; cat $*/build.out; exit 1)
>
>  %.nuke:
>  	+$(MAKE) -C $* nuke
>
>  %.test:
>  	+@echo test $*
> -	+@$(MAKE) -C $* test >$*/test.out 2>&1 || (echo TEST FAIL $*;
> cat $*/test.out; exit 1)
> +	+@$(MAKE) -C $* test.clean >$*/test.out 2>&1 || (echo TEST
> FAIL $*; cat $*/test.out; exit 1)
>
>  %.testshort:
>  	+@echo test $*
> -	+@$(MAKE) -C $* testshort >$*/test.out 2>&1 || (echo TEST FAIL
> $*; cat $*/test.out; exit 1)
> +	+@$(MAKE) -C $* testshort.clean >$*/test.out 2>&1 || (echo
> TEST FAIL $*; cat $*/test.out; exit 1)
>
>  %.bench:
>  	+$(MAKE) -C $* bench	
> Index: test/run
> ===================================================================
> --- a/test/run
> +++ b/test/run
> @@ -99,6 +99,7 @@
>  			echo $i >>pass.out
>  		fi
>  		echo $(awk 'NR==1{print $2}' $TMP2FILE) $D/$F >>times.out
> +		rm -f $F.$A $A.out
>  	) done
>  done | # clean up some stack noise
>  	egrep -v '^(r[0-9a-z]+|[cfg]s)  +0x'  |

[rsc, 2011-04-13 20:24:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=3b7654f28a02 ***

build: tidy intermediate files during build

This CL changes the behavior of 'make install' and 'make test'
in the src/cmd directory and the src/pkg directory to have
each recursive make clean up after itself immediately.

It does the same in test/run, removing $F.$A and $A.out
(the common byproducts) between runs.

On machines with slow disks and aggressive kernel caching,
cleaning up immediately can mean that the intermediate
objects never get written to disk.

This change eliminates almost all the disk waiting during
all.bash on my laptop (a Thinkpad X201s with an SSD running Linux).

147.50u 19.95s 277.34r	before
148.53u 21.64s 179.59r	after

R=golang-dev, r, iant2
CC=golang-dev
http://codereview.appspot.com/4413042