Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

Issue 4376046: code review 4376046: gofix: be more conservative about rewrite to os.Create (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by rsc
Modified:
12 years, 11 months ago
Reviewers:
r
CC:
golang-dev
Visibility:
Public.

Description

gofix: be more conservative about rewrite to os.Create Rewrite only if we understood all the flags we saw.

Patch Set 1 #

Patch Set 2 : diff -r 1e5952da8be6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1e5952da8be6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8b55e8fccd53 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/cmd/gofix/osopen.go View 1 3 chunks +13 lines, -10 lines 0 comments Download
M src/cmd/gofix/osopen_test.go View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2011-04-08 03:47:12 UTC) #1
r
LGTM i was about to do the same
12 years, 11 months ago (2011-04-08 05:45:42 UTC) #2
rsc
*** Abandoned ***
12 years, 11 months ago (2011-04-08 15:09:38 UTC) #3
rsc
12 years, 11 months ago (2011-04-08 15:15:27 UTC) #4
Really *** Submitted ***, but intermittent network
connectivity confuses hg.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b