Issue 4370041: code review 4370041: syscall: Add DT_* and MADV_* constants on Linux.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4370041: code review 4370041: syscall: Add DT_* and MADV_* constants on Linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by albert.strasheim

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, agl1, golang-dev

Visibility:
Public.

Description

syscall: Add DT_* and MADV_* constants on Linux.

Patch Set 1 #

Patch Set 2 : diff -r b002b8e25d25 https://go.googlecode.com/hg #

Patch Set 3 : diff -r b002b8e25d25 https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_linux_386.go	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_linux_amd64.go	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsysnum_linux_386.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsysnum_linux_amd64.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

albert.strasheim

Hello rsc, agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-04-06 04:46:37 UTC) #1

rsc

13 years, 11 months ago (2011-04-06 20:19:26 UTC) #3

*** Submitted as 5a0dbcb6e9c1 ***

syscall: Add DT_* and MADV_* constants on Linux.

R=rsc, agl1
CC=golang-dev
http://codereview.appspot.com/4370041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages