code review 4351048: http: fix Transport connection re-use race

http: fix Transport connection re-use race

A connection shouldn't be made available
for re-use until its body has been consumed.

(except in the case of pipelining, which isn't
implemented yet)

This CL fixes some issues seen with heavy load
against Amazon S3.

Subtle implementation detail: to prevent a race
with the client requesting a new connection
before previous one is returned, we actually
have to call putIdleConnection _before_ we
return from the final Read/Close call on the
http.Response.Body.

[bradfitz, 2011-04-05 01:59:43]

Hello rsc, adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-04-05 02:11:42]

LGTM

But wait for rsc, I suppose.

[rsc, 2011-04-05 02:17:45]

LGTM

[bradfitz, 2011-04-05 02:22:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=e7238799f6de ***

http: fix Transport connection re-use race

A connection shouldn't be made available
for re-use until its body has been consumed.

(except in the case of pipelining, which isn't
implemented yet)

This CL fixes some issues seen with heavy load
against Amazon S3.

Subtle implementation detail: to prevent a race
with the client requesting a new connection
before previous one is returned, we actually
have to call putIdleConnection _before_ we
return from the final Read/Close call on the
http.Response.Body.

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/4351048