code review 43240043: go.tools/godoc/static: add 'fmtImportEl' option to play...

go.tools/godoc/static: add 'fmtImportEl' option to playground

The 'fmtImportEl' option lets the called specify a checkbox element
that determines whether to send the 'imports=true' key/value pair when
calling '/fmt'.

[adg, 2013-12-17 07:02:04]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2013-12-17 08:22:39]

LGTM



On Mon, Dec 16, 2013 at 11:02 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/godoc/static: add 'fmtImportEl' option to playground
>
> The 'fmtImportEl' option lets the called specify a checkbox element
> that determines whether to send the 'imports=true' key/value pair when
> calling '/fmt'.
>
> Please review this at https://codereview.appspot.com/43240043/
>
> Affected files (+16, -4 lines):
>   M godoc/static/playground.js
>   M godoc/static/static.go
>
>
> Index: godoc/static/playground.js
> ===================================================================
> --- a/godoc/static/playground.js
> +++ b/godoc/static/playground.js
> @@ -228,6 +228,7 @@
>    //  outputEl - program output element
>    //  runEl - run button element
>    //  fmtEl - fmt button element (optional)
> +  //  fmtImportEl - fmt "imports" checkbox element (optional)
>    //  shareEl - share button element (optional)
>    //  shareURLEl - share URL text input element (optional)
>    //  shareRedirect - base URL to redirect to on share (optional)
> @@ -343,10 +344,15 @@
>        loading();
>        running = transport.Run(body(), highlightOutput(
> PlaygroundOutput(output[0])));
>      }
> +
>      function fmt() {
>        loading();
> +      var data = {"body": body()};
> +      if ($(opts.fmtImportEl).is(":checked")) {
> +        data["imports"] = "true";
> +      }
>        $.ajax("/fmt", {
> -        data: {"body": body()},
> +        data: data,
>          type: "POST",
>          dataType: "json",
>          success: function(data) {
> @@ -362,7 +368,7 @@
>
>      $(opts.runEl).click(run);
>      $(opts.fmtEl).click(fmt);
> -
> +
>      if (opts.shareEl !== null && (opts.shareURLEl !== null ||
> opts.shareRedirect !== null)) {
>        var shareURL;
>        if (opts.shareURLEl) {
> Index: godoc/static/static.go
> ===================================================================
> --- a/godoc/static/static.go
> +++ b/godoc/static/static.go
> @@ -1166,6 +1166,7 @@
>    //  outputEl - program output element
>    //  runEl - run button element
>    //  fmtEl - fmt button element (optional)
> +  //  fmtImportEl - fmt "imports" checkbox element (optional)
>    //  shareEl - share button element (optional)
>    //  shareURLEl - share URL text input element (optional)
>    //  shareRedirect - base URL to redirect to on share (optional)
> @@ -1281,10 +1282,15 @@
>        loading();
>        running = transport.Run(body(), highlightOutput(
> PlaygroundOutput(output[0])));
>      }
> +
>      function fmt() {
>        loading();
> +      var data = {"body": body()};
> +      if ($(opts.fmtImportEl).is(":checked")) {
> +        data["imports"] = "true";
> +      }
>        $.ajax("/fmt", {
> -        data: {"body": body()},
> +        data: data,
>          type: "POST",
>          dataType: "json",
>          success: function(data) {
> @@ -1300,7 +1306,7 @@
>
>      $(opts.runEl).click(run);
>      $(opts.fmtEl).click(fmt);
> -
> +
>      if (opts.shareEl !== null && (opts.shareURLEl !== null ||
> opts.shareRedirect !== null)) {
>        var shareURL;
>        if (opts.shareURLEl) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[adg, 2013-12-17 22:32:58]

*** Submitted as
https://code.google.com/p/go/source/detail?r=d8700e870053&repo=tools ***

go.tools/godoc/static: add 'fmtImportEl' option to playground

The 'fmtImportEl' option lets the called specify a checkbox element
that determines whether to send the 'imports=true' key/value pair when
calling '/fmt'.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/43240043