code review 43220043: go-playground: add "Imports" checkbox to enable import ...

go-playground: add "Imports" checkbox to enable import rewriting

[adg, 2013-12-17 06:53:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-playground

[adg, 2013-12-17 07:02:02]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-12-17 08:23:49]

LGTM

But would prefer to see this running somewhere first to do visual review.
 But I trust your design sense.

Would also prefer to see goimports moved off of my github account.



On Mon, Dec 16, 2013 at 11:02 PM, <adg@golang.org> wrote:

> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/43220043/
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[r, 2013-12-17 15:01:09]

fixes issue 6947?

[crawshaw1, 2013-12-17 15:19:43]

On Tue, Dec 17, 2013 at 3:23 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Would also prefer to see goimports moved off of my github account.

I started a CL to move it into go.tools, but I see goimports has
several contributors, and I am unsure how you have been tracking them.
Also you should accept adg's package split pull request first, so that
we can have go.tools/goimports and go.tools/cmd/goimports.

>
>
> On Mon, Dec 16, 2013 at 11:02 PM, <adg@golang.org> wrote:
>>
>> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>>
>> Please take another look.
>>
>>
>> https://codereview.appspot.com/43220043/
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[adg, 2013-12-17 21:36:11]

On 18 December 2013 02:00, Rob Pike <r@golang.org> wrote:

> fixes issue 6947?


This is the go-playground repo, which has a separate (disabled) issue
tracker. Will update the issue when submitted.

[adg, 2013-12-17 21:36:31]

On 17 December 2013 19:23, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> But would prefer to see this running somewhere first to do visual review.
>  But I trust your design sense.


http://play.go-build.appspot.com/

[adg, 2013-12-17 21:38:14]

On 18 December 2013 02:19, David Crawshaw <crawshaw@google.com> wrote:

> I started a CL to move it into go.tools, but I see goimports has
> several contributors, and I am unsure how you have been tracking them.
>

I believe they should all be in go's A+C files. Brad can confirm.


>  Also you should accept adg's package split pull request first, so that
> we can have go.tools/goimports and go.tools/cmd/goimports.
>

SGTM

[bradfitz, 2013-12-17 21:56:19]

There's exactly one contribution from a non-Go CONTRIBUTOR:

I typo-ed "explicitly":

commit b8497e6965d75b38d3417a3812299b190206e00e
Author: Nicolas Kaiser <nikai@nikai.net>
Date:   Sat Nov 16 20:17:07 2013 +0100

    fix typo in README

diff --git a/README b/README
index 7fa7762..a42db68 100644
--- a/README
+++ b/README
@@ -33,7 +33,7 @@ which is best practice anyway, like:

     import "github.com/you/foo" // assumes this is package "foo"

-If they don't match, explictly name the package name in your import
+If they don't match, explicitly name the package name in your import
 line:

     import foo "github.com/you/not-quite-foo"




On Tue, Dec 17, 2013 at 1:37 PM, Andrew Gerrand <adg@golang.org> wrote:

>
> On 18 December 2013 02:19, David Crawshaw <crawshaw@google.com> wrote:
>
>> I started a CL to move it into go.tools, but I see goimports has
>> several contributors, and I am unsure how you have been tracking them.
>>
>
> I believe they should all be in go's A+C files. Brad can confirm.
>
>
>>  Also you should accept adg's package split pull request first, so that
>> we can have go.tools/goimports and go.tools/cmd/goimports.
>>
>
> SGTM
>

[adg, 2013-12-17 22:03:49]

On 18 December 2013 08:56, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Author: Nicolas Kaiser <nikai@nikai.net>
>

They've signed the CLA.

https://codereview.appspot.com/43620043

[bradfitz, 2013-12-17 22:21:43]

phew



On Tue, Dec 17, 2013 at 2:03 PM, Andrew Gerrand <adg@golang.org> wrote:

>
> On 18 December 2013 08:56, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>
>> Author: Nicolas Kaiser <nikai@nikai.net>
>>
>
> They've signed the CLA.
>
> https://codereview.appspot.com/43620043
>

[adg, 2013-12-17 23:00:08]

*** Submitted as
https://code.google.com/p/go-playground/source/detail?r=55e4587ba8bf ***

go-playground: add "Imports" checkbox to enable import rewriting

R=golang-dev, bradfitz, r, crawshaw
CC=golang-dev
https://codereview.appspot.com/43220043