Issue 4317043: code review 4317043: testing: set up structure for faster testing using the ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4317043: code review 4317043: testing: set up structure for faster testing using the ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

testing: set up structure for faster testing using the new -test.short flag. New make target "testshort" runs "gotest -test.short" and is invoked by run.bash, which is invoked by all.bash. Use -test.short to make one package (crypto ecdsa) run much faster. More changes to come. Once this is in, I will update the long-running tests to use the new flag.

Patch Set 1 #

Patch Set 2 : diff -r 56b847e640f3 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -2 lines)			Patch
M	src/Make.pkg	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/Makefile	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/goinstall/Makefile	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gotest/doc.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gotype/Makefile	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/Makefile	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/ecdsa/ecdsa_test.go	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/testing/testing.go	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/run.bash	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-25 21:42:23 UTC) #1

14 years, 1 month ago (2011-03-25 21:50:52 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=60a2de796cde ***

testing: set up structure for faster testing using the new -test.short flag.
New make target "testshort" runs "gotest -test.short" and is invoked
by run.bash, which is invoked by all.bash.

Use -test.short to make one package (crypto ecdsa) run much faster.
More changes to come.

Once this is in, I will update the long-running tests to use the new flag.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4317043

Expand All Messages | Collapse All Messages