Issue 4316051: code review 4316051: gc: avoid saying same error 3 times

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4316051: code review 4316051: gc: avoid saying same error 3 times (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: avoid saying same error 3 times

Patch Set 1 #

Patch Set 2 : diff -r 2f3e8f3c912e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a15522fba283 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b40eec05bdaf https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	src/cmd/gc/const.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/gc/subr.c	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/ddd1.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-02 00:52:37 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=82050f8e7881 *** gc: avoid saying same error 3 times R=ken2 CC=golang-dev http://codereview.appspot.com/4316051

13 years, 11 months ago (2011-04-02 00:52:40 UTC) #2

ken3

lgtm i thought there was a uchar flag in Node that was set on a ...

13 years, 11 months ago (2011-04-02 07:06:43 UTC) #3

rsc

13 years, 11 months ago (2011-04-02 15:08:52 UTC) #4

> i thought there was a uchar flag in
> Node that was set on a diagnostic.
> that mechanism could be used here too.

the problem is i want the second message
not the first, since the second gives more context.
so i set the flag temporarily.

russ

Expand All Messages | Collapse All Messages