Issue 4314044: code review 4314044: testing: shorten some more tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4314044: code review 4314044: testing: shorten some more tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by r

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 8a43583eabc3 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -18 lines)			Patch
M	src/pkg/archive/tar/writer_test.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/big/int_test.go	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/pkg/container/vector/numbers_test.go	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/elliptic/elliptic_test.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_messages_test.go	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/exp/eval/eval_test.go	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/pkg/fmt/fmt_test.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/printer_test.go	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/pkg/image/png/reader_test.go	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	src/pkg/image/png/writer_test.go	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/json/decode_test.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/json/scanner_test.go	View		5 chunks	+20 lines, -5 lines	0 comments	Download
M	src/pkg/netchan/netchan_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/utf8/string_test.go	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-26 18:12:37 UTC) #1

rsc

LGTM http://codereview.appspot.com/4314044/diff/1/src/pkg/big/int_test.go File src/pkg/big/int_test.go (right): http://codereview.appspot.com/4314044/diff/1/src/pkg/big/int_test.go#newcode724 src/pkg/big/int_test.go:724: if testing.Short() { I'd rather make these shorter ...

14 years ago (2011-03-26 18:17:48 UTC) #2

14 years ago (2011-03-26 18:25:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=20b1f499456d ***

testing: shorten some more tests

R=rsc
CC=golang-dev
http://codereview.appspot.com/4314044

Expand All Messages | Collapse All Messages