Issue 4312053: code review 4312053: runtime: always set *received in chanrecv.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4312053: code review 4312053: runtime: always set *received in chanrecv. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by iant

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: always set *received in chanrecv. Also fix comment. The only caller of chanrecv initializes the value to false, so this patch makes no difference at present. But it seems like the right thing to do.

Patch Set 1 #

Patch Set 2 : diff -r 14c82998b18e https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/runtime/chan.c	View		3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-03-25 15:17:46 UTC) #1

iant

13 years, 1 month ago (2011-03-25 17:36:24 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5fe7120df18a ***

runtime: always set *received in chanrecv.

Also fix comment.

The only caller of chanrecv initializes the value to false, so
this patch makes no difference at present.  But it seems like
the right thing to do.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4312053

Expand All Messages | Collapse All Messages