Issue 4309042: code review 4309042: go/printer: Revert API change of CL 4274075.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4309042: code review 4309042: go/printer: Revert API change of CL 4274075. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by gri

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

go/printer: Revert API change of CL 4274075. Revert changes to printer.Config. Pass in the nodeSizes map trough an internal helper function.

Patch Set 1 #

Patch Set 2 : diff -r 53d99c6f0ef8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 53d99c6f0ef8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 53d99c6f0ef8 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -25 lines)			Patch
M	src/cmd/godoc/godoc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gofix/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gofix/main_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gofmt/gofmt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1 2	4 chunks	+21 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-22 20:54:29 UTC) #1

gri

14 years, 1 month ago (2011-03-22 21:13:44 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=94fab267e96b ***

go/printer: Revert API change of CL 4274075.

Revert changes to printer.Config. Pass in the
nodeSizes map trough an internal helper function.

R=golang-dev, rsc1
CC=golang-dev
http://codereview.appspot.com/4309042

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages