Issue 4303042: code review 4303042: go/printer, gofmt: simplify struct formatting and respe...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4303042: code review 4303042: go/printer, gofmt: simplify struct formatting and respe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by gri

Modified:
13 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: simplify struct formatting and respect line breaks Also: gofmt src misc Fixes issue 1627.

Patch Set 1 #

Patch Set 2 : diff -r e9691d99ab75 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e9691d99ab75 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3a85cba563d6 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3a85cba563d6 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 3a85cba563d6 https://go.googlecode.com/hg/ #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -46 lines)			Patch
M	misc/cgo/test/callback.go	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	misc/cgo/test/cgo_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	misc/cgo/test/issue1560.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1 2 3	15 chunks	+18 lines, -27 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.golden	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.input	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 12 months ago (2011-03-21 20:50:32 UTC) #1

gri

13 years, 11 months ago (2011-03-22 18:05:33 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4792582b3c2d ***

go/printer, gofmt: simplify struct formatting and respect line breaks

Also: gofmt src misc

Fixes issue 1627.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4303042

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages