Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 4296042: code review 4296042: runtime: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by rsc
Modified:
13 years, 11 months ago
Reviewers:
CC:
adg, dave_cheney.net, r, golang-dev
Visibility:
Public.

Description

runtime: fix arm build

Patch Set 1 #

Patch Set 2 : diff -r 31d7feb9281b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 31d7feb9281b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8406058c64f7 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -26 lines) Patch
M src/pkg/runtime/arm/traceback.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/linux/arm/defs.h View 1 4 chunks +27 lines, -15 lines 0 comments Download
M src/pkg/runtime/linux/arm/signal.c View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/runtime/linux/arm/sys.s View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/linux/defs_arm.c View 1 4 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-03-25 00:48:11 UTC) #1
dave_cheney.net
Looks good, worked for me.
13 years, 11 months ago (2011-03-25 06:38:42 UTC) #2
r
LGTM
13 years, 11 months ago (2011-03-25 06:45:21 UTC) #3
rsc
13 years, 11 months ago (2011-03-25 16:30:52 UTC) #4
*** Submitted as 26976ac2a837 ***

runtime: fix arm build

R=adg, dfc, r
CC=golang-dev
http://codereview.appspot.com/4296042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b