Issue 4285063: code review 4285063: runtime: fix freebsd-amd64 (and part of 386)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4285063: code review 4285063: runtime: fix freebsd-amd64 (and part of 386) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by adg

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix freebsd-amd64 (and part of 386)

Patch Set 1 #

Patch Set 2 : diff -r 31eae9ad9d23 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 31eae9ad9d23 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d5a28a74b748 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d5a28a74b748 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r d5a28a74b748 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
M	src/pkg/runtime/freebsd/386/signal.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/defs.h	View	1	5 chunks	+19 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/signal.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/freebsd/defs.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/os.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-03-23 23:45:55 UTC) #1

adg

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-03-24 00:26:56 UTC) #2

adg

13 years, 11 months ago (2011-03-24 00:45:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=957d16f928d6 ***

runtime: fix freebsd-amd64 (and part of 386)

R=rsc
CC=golang-dev
http://codereview.appspot.com/4285063

Expand All Messages | Collapse All Messages