Issue 4284070: code review 4284070: go/token: use array instead of map for token->string table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4284070: code review 4284070: go/token: use array instead of map for token->string table (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by gri

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/token: use array instead of map for token->string table

Patch Set 1 #

Patch Set 2 : diff -r ea196694b740 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ea196694b740 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9eeaf3d9215c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9eeaf3d9215c https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	src/pkg/go/token/token.go	View	1 2 3 4	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-03-28 20:20:00 UTC) #1

rsc

LGTM Do you need to check for "" ? (Is the index set dense?) Russ

13 years, 1 month ago (2011-03-28 20:28:27 UTC) #2

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 1 month ago (2011-03-28 20:32:42 UTC) #3

gri

good point. there are holes. checking now. On Mon, Mar 28, 2011 at 1:28 PM, ...

13 years, 1 month ago (2011-03-28 20:32:44 UTC) #4

rsc

LGTM It would be nice to leave the return value unnamed just because it shows ...

13 years, 1 month ago (2011-03-28 20:36:39 UTC) #5

gri

13 years, 1 month ago (2011-03-28 20:38:30 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=242439bc6eee ***

go/token: use array instead of map for token->string table

R=rsc
CC=golang-dev
http://codereview.appspot.com/4284070

Expand All Messages | Collapse All Messages