Issue 4278052: code review 4278052: gob: keep free lists of encoder and decoder states.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4278052: code review 4278052: gob: keep free lists of encoder and decoder states. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by r

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, rsc1, golang-dev

Visibility:
Public.

Description

gob: keep free lists of encoder and decoder states. Avoids 3 mallocs in a round trip encoding/decoding a struct.

Patch Set 1 #

Patch Set 2 : diff -r 7d5e14d39181 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -40 lines)			Patch
M	src/pkg/gob/codec_test.go	View	20 chunks	+29 lines, -22 lines	0 comments	Download
M	src/pkg/gob/decode.go	View	7 chunks	+22 lines, -7 lines	0 comments	Download
M	src/pkg/gob/decoder.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/gob/encode.go	View	10 chunks	+30 lines, -8 lines	0 comments	Download
M	src/pkg/gob/encoder.go	View	4 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-03-16 00:47:05 UTC) #1

13 years, 1 month ago (2011-03-16 04:30:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a86a8e8ece73 ***

gob: keep free lists of encoder and decoder states.
Avoids 3 mallocs in a round trip encoding/decoding a struct.

R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/4278052

Expand All Messages | Collapse All Messages