Issue 4275078: code review 4275078: test: match gccgo error messages for label.go and label1.go.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4275078: code review 4275078: test: match gccgo error messages for label.go and label1.go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by iant

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

test: match gccgo error messages for label.go and label1.go. label.go:30:1: error: label ‘L6’ already defined label.go:28:1: note: previous definition of ‘L6’ was here label.go:23:1: error: label ‘L4’ defined and not used label.go:52:2: error: label ‘defalt’ defined and not used label.go:17:1: error: label ‘L2’ defined and not used label.go:26:1: error: label ‘L5’ defined and not used label.go:20:1: error: label ‘L3’ defined and not used label.go:14:1: error: label ‘L1’ defined and not used label1.go:32:13: error: invalid continue label ‘L2’ label1.go:44:13: error: invalid continue label ‘L3’ label1.go:52:10: error: invalid break label ‘L4’ label1.go:55:13: error: invalid continue label ‘L4’ label1.go:65:9: error: invalid break label ‘L5’ label1.go:68:12: error: invalid continue label ‘L5’ label1.go:76:10: error: invalid break label ‘L1’ label1.go:79:13: error: invalid continue label ‘L1’

Patch Set 1 #

Patch Set 2 : diff -r 5fe7120df18a https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	test/label.go	View		2 chunks	+8 lines, -8 lines	0 comments	Download
	M	test/label1.go	View		5 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-03-25 15:44:34 UTC) #1

iant

13 years, 1 month ago (2011-03-25 17:36:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c5c646b5513f ***

test: match gccgo error messages for label.go and label1.go.

label.go:30:1: error: label ‘L6’ already defined
label.go:28:1: note: previous definition of ‘L6’ was here
label.go:23:1: error: label ‘L4’ defined and not used
label.go:52:2: error: label ‘defalt’ defined and not used
label.go:17:1: error: label ‘L2’ defined and not used
label.go:26:1: error: label ‘L5’ defined and not used
label.go:20:1: error: label ‘L3’ defined and not used
label.go:14:1: error: label ‘L1’ defined and not used

label1.go:32:13: error: invalid continue label ‘L2’
label1.go:44:13: error: invalid continue label ‘L3’
label1.go:52:10: error: invalid break label ‘L4’
label1.go:55:13: error: invalid continue label ‘L4’
label1.go:65:9: error: invalid break label ‘L5’
label1.go:68:12: error: invalid continue label ‘L5’
label1.go:76:10: error: invalid break label ‘L1’
label1.go:79:13: error: invalid continue label ‘L1’

R=rsc
CC=golang-dev
http://codereview.appspot.com/4275078

Expand All Messages | Collapse All Messages