Issue 4272066: code review 4272066: testing: add -cpu.profile flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4272066: code review 4272066: testing: add -cpu.profile flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

testing: add -test.cpuprofile flag

Patch Set 1 #

Patch Set 2 : diff -r 1ca16d1788ba https://go.googlecode.com/hg #

Total comments: 2

Patch Set 3 : diff -r b5c246d30318 https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -17 lines)			Patch
M	src/cmd/gotest/gotest	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/cmd/prof/gopprof	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/testing/testing.go	View	1 2	4 chunks	+35 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-03-23 19:26:02 UTC) #1

LGTM but update CL desc and refactor if you like my suggestion http://codereview.appspot.com/4272066/diff/2001/src/pkg/testing/testing.go File src/pkg/testing/testing.go ...

13 years, 11 months ago (2011-03-23 19:39:16 UTC) #2

rsc

13 years, 11 months ago (2011-03-23 22:17:16 UTC) #3

*** Submitted as 31eae9ad9d23 ***

testing: add -test.cpuprofile flag

R=r
CC=golang-dev
http://codereview.appspot.com/4272066

Expand All Messages | Collapse All Messages