Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 4264050: code review 4264050: gc: unsafe.Pointer is not a pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by rsc
Modified:
14 years ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: unsafe.Pointer is not a pointer Change unsafe.Pointer to be its own kind of type, instead of making it equivalent to *any. The change complicates import and export but avoids the need to find all the places that operate on pointers but should not operate on unsafe.Pointer. Fixes issue 1566. (a different way) Fixes issue 1582.

Patch Set 1 #

Patch Set 2 : diff -r af83aa41994c https://go.googlecode.com/hg #

Patch Set 3 : diff -r c2fd8ff47c0c https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -22 lines) Patch
M src/cmd/gc/align.c View 1 4 chunks +12 lines, -0 lines 0 comments Download
M src/cmd/gc/builtin.c.boot View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/const.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/dcl.c View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/gc/reflect.c View 1 7 chunks +6 lines, -12 lines 0 comments Download
M src/cmd/gc/subr.c View 1 5 chunks +12 lines, -4 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/gc/unsafe.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug325.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
14 years ago (2011-03-07 20:10:00 UTC) #1
rsc
*** Submitted as 5ccb9b6f8cd1 *** gc: unsafe.Pointer is not a pointer Change unsafe.Pointer to be ...
14 years ago (2011-03-07 20:10:02 UTC) #2
ken3
14 years ago (2011-03-08 19:44:30 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b