Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 4257052: code review 4257052: doc/codelab/wiki: include into windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by brainman
Modified:
13 years ago
Reviewers:
CC:
adg, rsc, Joe Poirier, golang-dev
Visibility:
Public.

Description

doc/codelab/wiki: include into windows build

Patch Set 1 #

Patch Set 2 : diff -r 673e2876186d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 673e2876186d https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r 06fb9544cf52 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4cf2dfa78382 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M doc/codelab/wiki/Makefile View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M doc/codelab/wiki/test.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/codelab/wiki/wiki.html View 1 2 3 28 chunks +35 lines, -35 lines 0 comments Download
M src/run.bash View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9
brainman
Hello golang-dev@googlegroups.com (cc: Joe Poirier), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago (2011-03-03 02:08:38 UTC) #1
brainman
On 2011/03/03 02:08:38, brainman wrote: > Hello mailto:golang-dev@googlegroups.com (cc: Joe Poirier), > > I'd like ...
13 years, 1 month ago (2011-03-03 02:10:50 UTC) #2
adg
http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile File doc/codelab/wiki/Makefile (right): http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile#newcode12 doc/codelab/wiki/Makefile:12: P=4 I'm a bit grossed-out by this. Can we ...
13 years ago (2011-03-07 02:17:54 UTC) #3
rsc
http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile File doc/codelab/wiki/Makefile (right): http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile#newcode12 doc/codelab/wiki/Makefile:12: P=4 On 2011/03/07 02:17:54, adg wrote: > I'm a ...
13 years ago (2011-03-07 02:40:58 UTC) #4
brainman
Hello golang-dev@googlegroups.com, adg, rsc (cc: Joe Poirier, golang-dev@googlegroups.com), Please take another look.
13 years ago (2011-03-07 03:30:21 UTC) #5
brainman
Thank you Andrew and Russ. http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile File doc/codelab/wiki/Makefile (right): http://codereview.appspot.com/4257052/diff/4001/doc/codelab/wiki/Makefile#newcode12 doc/codelab/wiki/Makefile:12: P=4 On 2011/03/07 02:40:58, ...
13 years ago (2011-03-07 03:30:29 UTC) #6
rsc
LGTM
13 years ago (2011-03-07 03:39:48 UTC) #7
adg
LGTM
13 years ago (2011-03-07 03:45:11 UTC) #8
brainman
13 years ago (2011-03-07 04:48:46 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=4ea8f8f3c643 ***

doc/codelab/wiki: include into windows build

R=adg, rsc
CC=Joe Poirier, golang-dev
http://codereview.appspot.com/4257052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b