Issue 42570043: code review 42570043: unicode/utf16: add explicit tests for IsSurrogate

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 42570043: code review 42570043: unicode/utf16: add explicit tests for IsSurrogate (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dfc

Modified:
10 years, 4 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

unicode/utf16: add explicit tests for IsSurrogate Update issue 6956 Add tests for IsSurrogate.

Patch Set 1 #

Patch Set 2 : diff -r 1053bd434eaa https://code.google.com/p/go #

Patch Set 3 : diff -r 1053bd434eaa https://code.google.com/p/go #

Patch Set 4 : diff -r 3cb71b69695a https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	src/pkg/unicode/utf16/utf16_test.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dfc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2013-12-15 23:32:23 UTC) #1

dfc

Thanks r. Submitting. On Mon, Dec 16, 2013 at 11:04 AM, <r@golang.org> wrote: > LGTM ...

10 years, 4 months ago (2013-12-16 00:05:16 UTC) #3

dfc

10 years, 4 months ago (2013-12-16 00:15:45 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=bccf584859d6 ***

unicode/utf16: add explicit tests for IsSurrogate

Update issue 6956

Add tests for IsSurrogate.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/42570043

Expand All Messages | Collapse All Messages