code review 4256060: syscall: implement Reboot for linux.

syscall: implement Reboot for linux.

The published interface is the simple version of the syscall,
allowing all reboot functions except for the esoteric
LINUX_REBOOT_CMD_RESTART2.

[danderson, 2011-03-08 10:10:58]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-03-08 15:48:59]

LGTM

[bradfitz, 2011-03-08 15:54:55]

Actually, this breaks the amd64 linux build (i.e. my laptop)

make[1]: Entering directory `/home/bradfitz/go/src/pkg/syscall'
6g -o _go_.6 str.go syscall.go syscall_amd64.go syscall_linux.go
syscall_linux_amd64.go zerrors_linux_amd64.go zsyscall_linux_amd64.go
zsysnum_linux_amd64.go ztypes_linux_amd64.go  syscall_unix.go exec_unix.go 
6a asm_linux_amd64.s
syscall_linux.go:672: undefined: reboot
syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC1
syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC2
make[1]: *** [_go_.6] Error 1
make[1]: Leaving directory `/home/bradfitz/go/src/pkg/syscall'
make: *** [syscall.install] Error 2
make: *** Waiting for unfinished jobs....

Looks like you only defined reboot in zsyscall_linux_386 but call it from
syscall_linux.go (all arches).

[danderson, 2011-03-08 18:55:59]

Correct, I didn't have an amd64 linux on hand last night, so couldn't
regenerate the z* files appropriately. I'll regenerate them at the office
today and remail.

On Tue, Mar 8, 2011 at 07:54, <bradfitz@golang.org> wrote:

> Actually, this breaks the amd64 linux build (i.e. my laptop)
>
> make[1]: Entering directory `/home/bradfitz/go/src/pkg/syscall'
> 6g -o _go_.6 str.go syscall.go syscall_amd64.go syscall_linux.go
> syscall_linux_amd64.go zerrors_linux_amd64.go zsyscall_linux_amd64.go
> zsysnum_linux_amd64.go ztypes_linux_amd64.go  syscall_unix.go
> exec_unix.go
> 6a asm_linux_amd64.s
> syscall_linux.go:672: undefined: reboot
> syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC1
> syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC2
> make[1]: *** [_go_.6] Error 1
> make[1]: Leaving directory `/home/bradfitz/go/src/pkg/syscall'
> make: *** [syscall.install] Error 2
> make: *** Waiting for unfinished jobs....
>
> Looks like you only defined reboot in zsyscall_linux_386 but call it
> from syscall_linux.go (all arches).
>
>
> http://codereview.appspot.com/4256060/
>



-- 
Google Switzerland GmbH
Brandschenkestrasse 110,
Zurich, Switzerland
8002 Zurich

Identifikationsnummer:
CH-020.4.028.116-1

[danderson, 2011-03-09 01:23:42]

Patch expanded to include amd64 and arm z* files. Current HEAD is broken, but
this all works if I sync back to before the recent bad CL.

On 2011/03/08 18:55:59, danderson wrote:
> Correct, I didn't have an amd64 linux on hand last night, so couldn't
> regenerate the z* files appropriately. I'll regenerate them at the office
> today and remail.
> 
> On Tue, Mar 8, 2011 at 07:54, <mailto:bradfitz@golang.org> wrote:
> 
> > Actually, this breaks the amd64 linux build (i.e. my laptop)
> >
> > make[1]: Entering directory `/home/bradfitz/go/src/pkg/syscall'
> > 6g -o _go_.6 str.go syscall.go syscall_amd64.go syscall_linux.go
> > syscall_linux_amd64.go zerrors_linux_amd64.go zsyscall_linux_amd64.go
> > zsysnum_linux_amd64.go ztypes_linux_amd64.go  syscall_unix.go
> > exec_unix.go
> > 6a asm_linux_amd64.s
> > syscall_linux.go:672: undefined: reboot
> > syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC1
> > syscall_linux.go:672: undefined: LINUX_REBOOT_MAGIC2
> > make[1]: *** [_go_.6] Error 1
> > make[1]: Leaving directory `/home/bradfitz/go/src/pkg/syscall'
> > make: *** [syscall.install] Error 2
> > make: *** Waiting for unfinished jobs....
> >
> > Looks like you only defined reboot in zsyscall_linux_386 but call it
> > from syscall_linux.go (all arches).
> >
> >
> > http://codereview.appspot.com/4256060/
> >
> 
> 
> 
> -- 
> Google Switzerland GmbH
> Brandschenkestrasse 110,
> Zurich, Switzerland
> 8002 Zurich
> 
> Identifikationsnummer:
> CH-020.4.028.116-1

[bradfitzgoog, 2011-03-09 13:44:47]

LGTM

Builds on amd64 and 386 (with rsc's unsubmitted CL to fix amd64).  arm build
fails with unrelated reasons with this CL.

[bradfitz, 2011-03-09 13:45:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=d6739b5a84c6 ***

syscall: implement Reboot for linux.

The published interface is the simple version of the syscall,
allowing all reboot functions except for the esoteric
LINUX_REBOOT_CMD_RESTART2.

R=golang-dev, bradfitzgo, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4256060

Committer: Brad Fitzpatrick <bradfitz@golang.org>