Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1012)

Issue 4250063: code review 4250063: net: fix test for Solaris: gopher and http are not in /... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by iant
Modified:
14 years ago
Reviewers:
CC:
rsc, dsymonds, golang-dev
Visibility:
Public.

Description

net: fix test for Solaris: gopher and http are not in /etc/services.

Patch Set 1 #

Patch Set 2 : diff -r 767cb6367e28 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/pkg/net/port_test.go View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-03-07 23:10:31 UTC) #1
rsc
LGTM.
14 years ago (2011-03-07 23:17:00 UTC) #2
dsymonds
FYI Wow, retro.
14 years ago (2011-03-07 23:31:32 UTC) #3
iant
*** Submitted as http://code.google.com/p/go/source/detail?r=d2cbb3a8f64b *** net: fix test for Solaris: gopher and http are not ...
14 years ago (2011-03-07 23:31:44 UTC) #4
rsc
14 years ago (2011-03-08 02:26:12 UTC) #5
> Wow, retro.

If you're surprised, you have no idea.
Solaris is its own brand of time machine.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b