Issue 4245043: code review 4245043: runtime: use kernel-supplied cas on linux/arm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4245043: code review 4245043: runtime: use kernel-supplied cas on linux/arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rsc

Modified:
14 years ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

runtime: use kernel-supplied cas on linux/arm Using the kernel-supplied compare-and-swap code on linux/arm means that runtime doesn't have to care whether this is GOARM=5 or GOARM=6 anymore. Fixes issue 1494.

Patch Set 1 #

Patch Set 2 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 51e1539c025c https://go.googlecode.com/hg #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -129 lines)			Patch
M	src/pkg/runtime/Makefile	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/arm/asm.s	View	1 2 3	1 chunk	+31 lines, -0 lines	0 comments	Download
R	src/pkg/runtime/arm/cas5.s	View	1	1 chunk	+0 lines, -74 lines	0 comments	Download
R	src/pkg/runtime/arm/cas6.s	View	1	1 chunk	+0 lines, -52 lines	0 comments	Download
M	src/pkg/runtime/linux/arm/sys.s	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-25 18:14:04 UTC) #1

http://codereview.appspot.com/4245043/diff/3001/src/pkg/runtime/arm/asm.s File src/pkg/runtime/arm/asm.s (right): http://codereview.appspot.com/4245043/diff/3001/src/pkg/runtime/arm/asm.s#newcode278 src/pkg/runtime/arm/asm.s:278: // bool armcas(int32 *val, int32 old, int32 new) i'm ...

14 years ago (2011-02-25 18:18:03 UTC) #2

rsc

On Fri, Feb 25, 2011 at 13:18, <r@google.com> wrote: > > http://codereview.appspot.com/4245043/diff/3001/src/pkg/runtime/arm/asm.s > File src/pkg/runtime/arm/asm.s ...

14 years ago (2011-02-25 18:21:49 UTC) #3

rsc

14 years ago (2011-02-25 19:29:57 UTC) #5

*** Submitted as 5a47c03cf081 ***

runtime: use kernel-supplied cas on linux/arm

Using the kernel-supplied compare-and-swap code
on linux/arm means that runtime doesn't have to care
whether this is GOARM=5 or GOARM=6 anymore.

Fixes issue 1494.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4245043

Expand All Messages | Collapse All Messages