Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1421)

Issue 4240100: code review 4240100: Effective Go: some small cleanups. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
CC:
golang-dev, gri, adg, iant
Visibility:
Public.

Description

Effective Go: some small cleanups. Add discussion of getters. Add example using a map as a set.

Patch Set 1 #

Total comments: 5

Patch Set 2 : diff -r ee5e80c62862 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r ee5e80c62862 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -21 lines) Patch
M doc/effective_go.html View 1 2 17 chunks +60 lines, -21 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-03-09 23:25:10 UTC) #1
gri
LGTM http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode98 doc/effective_go.html:98: All Go code in the repository has been ...
13 years, 11 months ago (2011-03-09 23:34:28 UTC) #2
adg
LGTM http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode62 doc/effective_go.html:62: A custom tool, <code>gofmt</code>, reads a Go program ...
13 years, 11 months ago (2011-03-09 23:36:55 UTC) #3
iant
LGTM http://codereview.appspot.com/4240100/diff/3001/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4240100/diff/3001/doc/effective_go.html#newcode515 doc/effective_go.html:515: This is a example of a common situation ...
13 years, 11 months ago (2011-03-09 23:50:16 UTC) #4
r
13 years, 11 months ago (2011-03-10 00:47:47 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a04c14d2db22 ***

Effective Go: some small cleanups.
Add discussion of getters.
Add example using a map as a set.

R=golang-dev, gri, adg, iant
CC=golang-dev
http://codereview.appspot.com/4240100
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b