Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1697)

Issue 4230045: code review 4230045: gob: make recursive map and slice types work. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by r
Modified:
14 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gob: make recursive map and slice types work. Before this fix, types such as type T map[string]T caused infinite recursion in the gob implementation. Now they just work. Fixes issue 1518.

Patch Set 1 #

Patch Set 2 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -76 lines) Patch
M src/pkg/gob/codec_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/gob/decode.go View 12 chunks +37 lines, -26 lines 0 comments Download
M src/pkg/gob/encode.go View 6 chunks +25 lines, -18 lines 0 comments Download
M src/pkg/gob/encoder_test.go View 1 chunk +18 lines, -0 lines 0 comments Download
M src/pkg/gob/type.go View 8 chunks +71 lines, -27 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-02-25 00:12:21 UTC) #1
rsc1
LGTM
14 years ago (2011-02-25 06:29:14 UTC) #2
r
14 years ago (2011-02-25 17:45:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=035720db5bdc ***

gob: make recursive map and slice types work.

Before this fix, types such as
        type T map[string]T
caused infinite recursion in the gob implementation.
Now they just work.

Fixes issue 1518.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4230045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b