Issue 4217045: code review 4217045: godoc: accept symbolic links as path names provided to -path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4217045: code review 4217045: godoc: accept symbolic links as path names provided to -path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by gri

Modified:
13 years, 2 months ago

Reviewers:

CC:
r, dsymonds, r2, golang-dev

Visibility:
Public.

Description

godoc: accept symbolic links as path names provided to -path When providing addition file systems to godoc via -path, the path names may be symbolic links. Follow them. Also: better logging of error and special conditions.

Patch Set 1 #

Total comments: 3

Patch Set 2 : diff -r 2cc3fdd297ee https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	src/cmd/godoc/dirtrees.go	View	1	3 chunks	+18 lines, -3 lines	0 comments	Download
	M	src/cmd/godoc/godoc.go	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2011-02-24 22:57:45 UTC) #1

dsymonds

Perhaps there could be a path.Indirect function that recursively resolves symlinks? I've stumbled on this ...

13 years, 2 months ago (2011-02-24 23:16:50 UTC) #2

On Feb 24, 2011, at 3:16 PM, David Symonds wrote: > Perhaps there could be ...

13 years, 2 months ago (2011-02-24 23:21:21 UTC) #3

LGTM http://codereview.appspot.com/4217045/diff/1/src/cmd/godoc/dirtrees.go File src/cmd/godoc/dirtrees.go (right): http://codereview.appspot.com/4217045/diff/1/src/cmd/godoc/dirtrees.go#newcode198 src/cmd/godoc/dirtrees.go:198: // It's not uncommon that the root is ...

13 years, 2 months ago (2011-02-25 00:20:44 UTC) #4

gri

13 years, 2 months ago (2011-02-25 00:24:54 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a2846f4a9040 ***

godoc: accept symbolic links as path names provided to -path

When providing addition file systems to godoc via -path, the
path names may be symbolic links. Follow them.

Also: better logging of error and special conditions.

R=r, dsymonds, r2
CC=golang-dev
http://codereview.appspot.com/4217045

Expand All Messages | Collapse All Messages