code review 4217042: build: remove unused nacl conditional from Make.bash

build: remove unused nacl conditional from Make.bash

[dave_cheney.net, 2011-02-24 04:49:56]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-02-24 04:55:01]

LGTM

On 24 February 2011 15:49,  <dave@cheney.net> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: remove unused nacl conditional from Make.bash
>
> Please review this at http://codereview.appspot.com/4217042/
>
> Affected files:
>  M src/make.bash
>
>
> Index: src/make.bash
> ===================================================================
> --- a/src/make.bash
> +++ b/src/make.bash
> @@ -61,29 +61,24 @@
>  # pkg builds libcgo and the Go programs in cmd.
>  for i in lib9 libbio libmach cmd pkg
>  do
> -       case "$i-$GOOS-$GOARCH" in
> -       cmd/*-nacl-*)
> -               ;;
> -       *)
> -               # The ( ) here are to preserve the current directory
> -               # for the next round despite the cd $i below.
> -               # set -e does not apply to ( ) so we must explicitly
> -               # test the exit status.
> -               (
> -                       echo; echo; echo %%%% making $i %%%%; echo
> -                       cd "$GOROOT"/src/$i
> -                       case $i in
> -                       cmd)
> -                               bash make.bash
> -                               ;;
> -                       pkg)
> -                               gomake install
> -                               ;;
> -                       *)
> -                               gomake install
> -                       esac
> -               )  || exit 1
> -       esac
> +       # The ( ) here are to preserve the current directory
> +       # for the next round despite the cd $i below.
> +       # set -e does not apply to ( ) so we must explicitly
> +       # test the exit status.
> +       (
> +               echo; echo; echo %%%% making $i %%%%; echo
> +               cd "$GOROOT"/src/$i
> +               case $i in
> +               cmd)
> +                       bash make.bash
> +                       ;;
> +               pkg)
> +                       gomake install
> +                       ;;
> +               *)
> +                       gomake install
> +               esac
> +       )  || exit 1
>  done
>
>  # Print post-install messages.
>
>
>

[adg, 2011-02-24 04:57:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=9ddeec5149a1 ***

build: remove unused nacl conditional from make.bash

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4217042

Committer: Andrew Gerrand <adg@golang.org>