Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 419042: code review 419042: Revert previous change: complexN only converts to complexN. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by iant
Modified:
15 years ago
Reviewers:
CC:
r, golang-dev, ken2, rsc
Visibility:
Public.

Description

Revert previous change: complexN only converts to complexN. This was discussed with Ken and Russ. 6g has been changed, and both compilers now work this way. This avoids a double type conversion--first to the float type, then to the complex type.

Patch Set 1 #

Patch Set 2 : code review 419042: Revert previous change: complexN only converts to complexN. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/go_spec.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello r (cc: golang-dev@googlegroups.com, ken2, rsc), I'd like you to review this change.
15 years ago (2010-03-10 23:54:34 UTC) #1
r2
LGTM On Mar 10, 2010, at 3:54 PM, iant@golang.org wrote: > Reviewers: r, > > ...
15 years ago (2010-03-10 23:57:33 UTC) #2
iant
15 years ago (2010-03-11 04:38:47 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bfb207e74f30 ***

Revert previous change: complexN only converts to complexN.

This was discussed with Ken and Russ.  6g has been changed,
and both compilers now work this way.  This avoids a double
type conversion--first to the float type, then to the complex
type.

R=r
CC=golang-dev, ken2, rsc
http://codereview.appspot.com/419042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b