Issue 4188068: code review 4188068: exp/eval, go/printer: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4188068: code review 4188068: exp/eval, go/printer: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by gri

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/eval, go/printer: fix build There are some minor irregularities in the printer output (some paren's are present that should be removed), but these are unrelated issues. Will review in a 2nd step.

Patch Set 1 #

Patch Set 2 : diff -r 1a43d4433ad7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1a43d4433ad7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r abdfc427b506 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -36 lines)			Patch
M	src/pkg/exp/eval/stmt_test.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	1	3 chunks	+4 lines, -16 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View	1	5 chunks	+8 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-23 01:53:01 UTC) #1

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-02-23 02:14:00 UTC) #3

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=c166ed517af1 *** exp/eval, go/printer: fix build There are some minor irregularities in ...

14 years ago (2011-02-23 02:17:06 UTC) #4

LGTM

Expand All Messages | Collapse All Messages