code review 4184061: http: cleaned up HEAD request method.

http: cleaned up HEAD request method.

Removed a redefinition of the request URL which is never used and
redundant checking of the return value from send().

[padraig, 2011-02-20 20:04:20]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
/Users/Padraig/Documents/Code/go/.hg

[adg, 2011-02-21 23:01:35]

LGTM

On 21 February 2011 07:04,  <padraigkitterick@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> /Users/Padraig/Documents/Code/go/.hg
>
>
> Description:
> http: cleaned up HEAD request method.
>
> Removed a redefinition of the request URL which is never used and
> redundant checking of the return value from send().
>
> Please review this at http://codereview.appspot.com/4184061/
>
> Affected files:
>  M src/pkg/http/client.go
>
>
> Index: src/pkg/http/client.go
> ===================================================================
> --- a/src/pkg/http/client.go
> +++ b/src/pkg/http/client.go
> @@ -321,11 +321,7 @@
>        if req.URL, err = ParseURL(url); err != nil {
>                return
>        }
> -       url = req.URL.String()
> -       if r, err = send(&req); err != nil {
> -               return
> -       }
> -       return
> +       return send(&req)
>  }
>
>  type nopCloser struct {
>
>
>

[adg, 2011-02-21 23:40:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=bd5b6dc81178 ***

http: cleaned up HEAD request method.

Removed a redefinition of the request URL which is never used and
redundant checking of the return value from send().

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4184061

Committer: Andrew Gerrand <adg@golang.org>