Issue 4175049: code review 4175049: syscall: implement chmod() for win32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4175049: code review 4175049: syscall: implement chmod() for win32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mattn

Modified:
13 years, 2 months ago

Reviewers:
brainman, hector

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: implement chmod() for win32.

Patch Set 1 #

Patch Set 2 : diff -r d21418d773ba http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d21418d773ba http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d21418d773ba http://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -5 lines)			Patch
M	src/pkg/syscall/syscall_windows.go	View	1	2 chunks	+26 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows_386.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/

13 years, 2 months ago (2011-02-15 08:06:23 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=5a8a83c00638 *** syscall: implement chmod() for win32. R=golang-dev, rsc, brainman CC=golang-dev http://codereview.appspot.com/4175049 ...

13 years, 2 months ago (2011-02-16 05:25:17 UTC) #4

hector

I guess I should have reviewed this before it got committed, but while merging this ...

13 years, 2 months ago (2011-02-16 22:16:58 UTC) #5

brainman

13 years, 2 months ago (2011-02-16 23:09:59 UTC) #6

On 2011/02/16 22:16:58, hector wrote:
> ... failretval for SetFileAttributes is wrong.  ...

You are correct. I thought I checked, but I obviously missed it. Here is a fix:
http://codereview.appspot.com/4180052/.

> According
> to the MSDN docs the return value is a plain BOOL.  The way things stand
> currently, if SetFileAttributes returns FALSE the failure will not be
detected.

It appears mattn didn't use runtime/mkall.sh script to rebuild
zsyscall_windows_386.go, but adjusted it by hand. So the was no error in
zsyscall_windows_386.go, but //sys ... comment was out of sync, so I made the
adjustment.

Thank you for reporting.

Alex

Expand All Messages | Collapse All Messages